fix(api-client): Prevent ZodError on Sentry API 400 in validateEvents#1160
Open
sentry[bot] wants to merge 1 commit into
Open
fix(api-client): Prevent ZodError on Sentry API 400 in validateEvents#1160sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue MCP-SERVER-G3K, where
SentryApiService.validateEventswas throwing aZodErrorwhen the Sentry API returned a 400 Bad Request.The root cause was that
allowStatuses: [400]was explicitly passed tothis.request, which prevented the 400 HTTP response from being thrown as anApiError. Instead, the error payload (e.g.,{"detail": "..."}) was returned as a successful response body and then passed toEventsValidationResponseSchema.parse, leading to a Zod validation failure.The fix involves removing
allowStatuses: [400]from thethis.requestcall withinvalidateEvents. This ensures that 400 Bad Request responses from the Sentry API are correctly handled as errors, throwing anApiErroras expected, and preventing the malformed payload from reaching the Zod schema parser.Fixes MCP-SERVER-G3K
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.