Skip to content

fix(client): Handle empty JSON responses #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix(client): Handle empty JSON responses #1159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/mcp-core/src/api-client/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,11 @@ export class SentryApiService {
}

try {
return await response.json();
const text = await response.text();
if (text.trim() === "") {
return null;
}

@cursor cursor Bot Jul 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Null return breaks caller contracts

Medium Severity

parseJsonResponse now returns null for empty bodies, but every requestJSON caller still treats the result as required response data. Untyped call sites cast and read fields immediately, so empty responses become TypeErrors instead of the previous parse failure. Zod-backed call sites fail later with schema errors. Endpoints that intentionally return no body already go through request, not requestJSON.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d9aff4a. Configure here.

return JSON.parse(text);
} catch (error) {
// JSON parsing failure after successful response
throw new Error(
Expand Down
Loading