Repository navigation
feat(bun): Add incoming request options and sessions to bunServerIntegration - #25580
Open
Conversation
isaacs
added this pull request to stack #25589
October 20, 2026 22:30
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7e82d34. Configure here.
isaacs
marked this pull request as ready for review
October 20, 2026 23:46
isaacs
requested review from
JPeer264 and
mydea
and removed request for
a team
October 20, 2026 23:46
isaacs
force-pushed
the
isaacschlueter/js-3969-bun-bunserve-common-handling-of-options-and-sessions
branch
from
October 21, 2026 01:07
3563640 to
d84e648
Compare
isaacs
force-pushed
the
isaacschlueter/js-3969-bun-bunserve-common-handling-of-options-and-sessions
branch
from
October 21, 2026 01:12
d84e648 to
3563640
Compare
isaacs
force-pushed
the
isaacschlueter/js-3969-bun-bunserve-common-handling-of-options-and-sessions
branch
from
October 21, 2026 01:15
3563640 to
bdaba32
Compare
JPeer264
reviewed
Oct 21, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
Nice addition, just have two questions
isaacs
force-pushed
the
isaacschlueter/js-3969-bun-bunserve-common-handling-of-options-and-sessions
branch
from
October 21, 2026 14:16
bdaba32 to
44b5b4c
Compare
Contributor
size-limit report 📦Compared: 4247694 (PR test merge using develop at 17d5b89) Against: 3aafe9e (develop) · base run #63222
|
isaacs
force-pushed
the
isaacschlueter/js-3969-bun-bunserve-common-handling-of-options-and-sessions
branch
from
October 21, 2026 16:45
44b5b4c to
ff5ddbf
Compare
isaacs
force-pushed
the
isaacschlueter/js-3969-bun-bunserve-common-handling-of-options-and-sessions
branch
from
October 21, 2026 16:55
ff5ddbf to
ec55de6
Compare
isaacs
force-pushed
the
isaacschlueter/js-3969-bun-bunserve-common-handling-of-options-and-sessions
branch
from
October 21, 2026 17:25
ec55de6 to
a45bb60
Compare
Contributor
Optional E2E testsAll optional checks were successful. 6 successful. See the run. Successful checks
|
isaacs
force-pushed
the
isaacschlueter/js-3969-bun-bunserve-common-handling-of-options-and-sessions
branch
from
October 21, 2026 18:21
a45bb60 to
92a214b
Compare
isaacs
force-pushed
the
isaacschlueter/js-3969-bun-bunserve-common-handling-of-options-and-sessions
branch
from
October 22, 2026 15:37
92a214b to
f758460
Compare
JPeer264
approved these changes
Oct 22, 2026
…egration` `Bun.serve` took only `maxRequestBodySize`. A user could not skip body capture or spans for one route, and release health showed no request sessions or crash-free rate for `Bun.serve` apps. `denoServeIntegration` got these in #25493 and #25496. `bunServerIntegration` now accepts `ignoreRequestBody`, `ignoreIncomingRequests`, `ignoreStaticAssets`, `spans`, `onSpanCreated`, `onSpanEnd`, `sessions` and `sessionFlushingDelayMS`. They use the same names and behavior as `denoServeIntegration`, and the callbacks receive the web `Request`. The shared `ServerRequestOptions` check for `Bun.serve` now lists no unsupported options. When the SDK skips the span, it still continues the incoming trace, attaches request data and the body, records the session and captures errors. For a streamed response, `onSpanEnd` and the session end when the stream finishes. A user callback that throws does not fail the request. If `ignoreRequestBody` throws, the SDK skips the body, so it cannot leak data that the filter was meant to hide. Three changes in behavior: - `ignoreStaticAssets` defaults to `true`, so `GET` requests for files such as `favicon.ico` or `*.js` no longer create spans. - `spans` defaults to the client's tracing configuration, so the integration no longer starts spans when tracing is disabled. - Errors thrown for `OPTIONS` and `HEAD` requests are now captured. These requests also record sessions, as on Node and Deno. Fixes #25571 Fixes JS-3969 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
isaacs
force-pushed
the
isaacschlueter/js-3969-bun-bunserve-common-handling-of-options-and-sessions
branch
from
October 22, 2026 20:24
f758460 to
f75d0c1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bun.servetook onlymaxRequestBodySize. A user could not skip body capture or spans for one route, and release health showed no request sessions or crash-free rate forBun.serveapps.denoServeIntegrationgot these in #25493 and #25496.bunServerIntegrationnow acceptsignoreRequestBody,ignoreIncomingRequests,ignoreStaticAssets,spans,onSpanCreated,onSpanEnd,sessionsandsessionFlushingDelayMS. They use the same names and behavior asdenoServeIntegration, and the callbacks receive the webRequest. The sharedServerRequestOptionscheck forBun.servenow lists no unsupported options.When the SDK skips the span, it still continues the incoming trace, attaches request data and the body, records the session and captures errors. For a streamed response,
onSpanEndand the session end when the stream finishes. A user callback that throws does not fail the request. IfignoreRequestBodythrows, the SDK skips the body, so it cannot leak data that the filter was meant to hide.Three changes in behavior:
ignoreStaticAssetsdefaults totrue, soGETrequests for files such asfavicon.icoor*.jsno longer create spans.spansdefaults to the client's tracing configuration, so the integration no longer starts spans when tracing is disabled.OPTIONSandHEADrequests are now captured. These requests also record sessions, as on Node and Deno.Fixes #25571
Fixes JS-3969