feat(solidstart): Serve the managed tunnel on SolidStart v1 by logaretm · Pull Request #25423 · getsentry/sentry-javascript

logaretm · 2026-10-15T17:36:57Z

This PR wires SolidStart's SDK tunnel by adding a nitro 2 plugin that adds a request hook to handle tunneled requests.

The base path comes from server.baseURL, and the tunnel-basepath e2e variants cover dev and prod.

For reviewers: if you need an overview of what this is, refer to #25199.

closes #25465

github-actions · 2026-10-15T17:44:35Z

size-limit report 📦

Compared: 428a2aa (PR test merge using develop at 957bffb)

Against: ca4fc32 (develop) · base run #62950

⚠️ Baseline mismatch: 118 develop commit(s) in the PR build are missing from the baseline. Their size changes also affect this comparison. Compare commits. Re-run once develop's baseline build for 957bffb finishes.

Path	Size	% Change	Change
@sentry/browser	30.56 kB	+2.18%	+651 B 🔺
@sentry/browser - with treeshaking flags	28.54 kB	+1.76%	+491 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing	28.42 kB	+1.69%	+470 B 🔺
@sentry/browser (incl. Tracing)	52.8 kB	+1.35%	+702 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)	52.8 kB	+1.35%	+699 B 🔺
@sentry/browser (incl. Tracing, Profiling)	55.77 kB	+1.31%	+720 B 🔺
@sentry/browser (incl. Tracing, Replay)	92.47 kB	+0.68%	+621 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	81.21 kB	+0.61%	+492 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)	97.21 kB	+0.66%	+633 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)	110.2 kB	+0.63%	+687 B 🔺
@sentry/browser (incl. Feedback)	48.12 kB	+1.49%	+703 B 🔺
@sentry/browser (incl. sendFeedback)	35.63 kB	+1.9%	+664 B 🔺
@sentry/browser (incl. FeedbackAsync)	40.76 kB	+1.71%	+684 B 🔺
@sentry/browser (incl. Metrics)	31.57 kB	+2.05%	+634 B 🔺
@sentry/browser (incl. Logs)	31.84 kB	+2.02%	+629 B 🔺
@sentry/browser (incl. Metrics & Logs)	32.52 kB	+2.12%	+673 B 🔺
@sentry/react	32.37 kB	+1.99%	+630 B 🔺
@sentry/react (incl. Tracing)	55.05 kB	+1.17%	+635 B 🔺
@sentry/vue	38.71 kB	+1.7%	+646 B 🔺
@sentry/vue (incl. Tracing)	55.75 kB	+1.3%	+715 B 🔺
@sentry/svelte	30.59 kB	+2.2%	+656 B 🔺
@sentry/remix (Remix 3 client bundle)	57.84 kB	+1.27%	+722 B 🔺
CDN Bundle	32.14 kB	+1.5%	+474 B 🔺
CDN Bundle (incl. Tracing)	53.09 kB	+0.92%	+480 B 🔺
CDN Bundle (incl. Logs, Metrics)	34.34 kB	+1.4%	+471 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)	55.04 kB	+0.89%	+484 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)	75.29 kB	+0.67%	+499 B 🔺
CDN Bundle (incl. Tracing, Replay)	90.75 kB	+0.53%	+476 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	92.69 kB	+0.52%	+479 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	96.89 kB	+0.49%	+470 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	98.86 kB	+0.5%	+486 B 🔺
CDN Bundle - uncompressed	94.44 kB	+1.24%	+1.15 kB 🔺
CDN Bundle (incl. Tracing) - uncompressed	157.29 kB	+0.74%	+1.15 kB 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed	100.99 kB	+1.16%	+1.15 kB 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	163.26 kB	+0.72%	+1.15 kB 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	231.03 kB	+0.51%	+1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed	277.46 kB	+0.42%	+1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	283.42 kB	+0.41%	+1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	291.16 kB	+0.4%	+1.15 kB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	297.11 kB	+0.39%	+1.15 kB 🔺
@sentry/nextjs (client)	57.91 kB	+1.05%	+601 B 🔺
@sentry/sveltekit (client)	53.29 kB	+1.55%	+812 B 🔺
@sentry/core/server	43.52 kB	+4.13%	+1.73 kB 🔺
@sentry/core/browser	13.81 kB	-	-
@sentry/node	153.28 kB	+0.44%	+659 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)	81.58 kB	-	-
@sentry/node - without tracing	94.9 kB	+0.69%	+649 B 🔺
@sentry/node - without channel injection	133.92 kB	+0.47%	+616 B 🔺
@sentry/aws-serverless	103.15 kB	+0.7%	+710 B 🔺
@sentry/cloudflare (withSentry) - minified	213.13 kB	+0.96%	+2.02 kB 🔺
@sentry/cloudflare (withSentry)	528.73 kB	+0.94%	+4.9 kB 🔺
@sentry/nextjs/cloudflare (withSentry) - minified	232.75 kB	+0.88%	+2.01 kB 🔺

View base workflow run

logaretm · 2026-10-15T21:56:10Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

logaretm · 2026-10-16T02:14:51Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 76aedc2. Configure here.}

github-actions · 2026-10-21T15:48:58Z

One or more gzipped bundles increased by more than 500 bytes. If this increase is intentional, add the Accept Bundlesize Increase label to this PR to rerun and accept the check.

github-actions · 2026-10-22T10:15:31Z

👋 @isaacs, @mydea, @Lms24, @s1gr1d — Please review this PR when you get a chance!

`withSentry` registers a Nitro v2 plugin that answers tunnel requests from the `request` hook, before the app's middleware. It goes through `server.plugins` because vinxi's dev server ignores plugins that Nitro modules add.

… server too

…s' mock requests work

…les don't run after it

The tunnel handler now answers a request without one with a 411.

…op the variants other apps cover

…that repeats core's

github-actions · 2026-10-22T15:58:16Z

Optional E2E tests

All optional checks were successful. 1 successful. See the run.

Successful checks

	Check	Status
✅	CI: Optional E2E Tests / E2E solidstart-2 Test (optional)	Successful in 55s	Details

logaretm added this pull request to stack #25201 October 15, 2026 17:36

logaretm force-pushed the awad/tunnel-solidstart branch from 02a533b to 9dd69b3 Compare October 15, 2026 17:44

logaretm force-pushed the awad/tunnel-solidstart branch from 9dd69b3 to 1aeffb6 Compare October 15, 2026 18:16

logaretm force-pushed the awad/tunnel-solidstart branch from 1aeffb6 to a191b72 Compare October 15, 2026 18:26

logaretm force-pushed the awad/tunnel-solidstart branch from a191b72 to dc1137c Compare October 15, 2026 18:28

cursor Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread dev-packages/e2e-tests/test-applications/solidstart/tests/tunnel.test.ts Outdated

logaretm force-pushed the awad/tunnel-solidstart branch from dc1137c to 76aedc2 Compare October 16, 2026 01:51

cursor Bot reviewed Oct 16, 2026

View reviewed changes

logaretm force-pushed the awad/tunnel-solidstart branch from 76aedc2 to 9494c2d Compare October 16, 2026 02:25

logaretm force-pushed the awad/tunnel-solidstart branch from 9494c2d to b33703e Compare October 16, 2026 03:32

logaretm force-pushed the awad/tunnel-solidstart branch from b33703e to b81588b Compare October 16, 2026 04:23

logaretm force-pushed the awad/tunnel-solidstart branch from b81588b to 73f8123 Compare October 16, 2026 04:48

logaretm force-pushed the awad/tunnel-solidstart branch 2 times, most recently from 53720aa to fbd4278 Compare October 16, 2026 14:37

logaretm force-pushed the awad/tunnel-solidstart branch from fbd4278 to ed670ea Compare October 16, 2026 16:15

logaretm force-pushed the awad/tunnel-solidstart branch from 32042ac to 75248ba Compare October 19, 2026 19:12

logaretm marked this pull request as ready for review October 19, 2026 19:37

logaretm requested a review from a team as a code owner October 19, 2026 19:37

logaretm requested review from mydea and s1gr1d and removed request for a team October 19, 2026 19:37

logaretm requested review from a team as code owners October 19, 2026 20:08

logaretm requested review from Lms24 and isaacs and removed request for a team October 19, 2026 20:08

logaretm mentioned this pull request Oct 20, 2026

feat(core): Add managed tunnel helpers that derive the tunnel path from the DSN #25199

Open

logaretm added 13 commits October 22, 2026 11:44

feat(solidstart): Serve the managed tunnel on SolidStart v1

fd9ceb8

`withSentry` registers a Nitro v2 plugin that answers tunnel requests from the `request` hook, before the app's middleware. It goes through `server.plugins` because vinxi's dev server ignores plugins that Nitro modules add.

fix(solidstart): Serve the managed tunnel under server.baseURL

e312ad6

test(solidstart): Check the managed tunnel on SolidStart 2

27a012f

test(solidstart): Check the managed tunnel under the SolidStart 2 dev…

7f94fe8

… server too

test(solidstart): Check the managed tunnel under vinxi dev too

3f26e1d

fix(solidstart): Normalize the tunnel base path with the core util

b63a725

fix(solidstart): Read the tunnel request with h3 so serverless preset…

f4db9d5

…s' mock requests work

fix(solidstart): Serve the tunnel from the first h3 layer so route ru…

69a69f0

…les don't run after it

ref(solidstart): Report the base path once with setManagedTunnelDefaults

ce34906

test(solidstart): Send Content-Length with the tunnel test requests

30d5acb

The tunnel handler now answers a request without one with a 411.

test(solidstart): Race the tunnel span with the shared helper, and dr…

3ab7151

…op the variants other apps cover

ref(solidstart): Let core skip an empty base path, and drop the test …

9462031

…that repeats core's

ref: Import the internal tunnel helpers under their _INTERNAL_ names

78dbabc

Navigation Menu

Repository navigation

feat(solidstart): Serve the managed tunnel on SolidStart v1 - #25423

feat(solidstart): Serve the managed tunnel on SolidStart v1#25423
logaretm wants to merge 13 commits into
awad/tunnel-react-routerfrom
awad/tunnel-solidstart

logaretm commented Oct 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

logaretm commented Oct 15, 2026

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

logaretm commented Oct 16, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 22, 2026

Uh oh!

github-actions Bot commented Oct 22, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

logaretm commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

logaretm commented Oct 15, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

logaretm commented Oct 16, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 22, 2026

Uh oh!

github-actions Bot commented Oct 22, 2026

Optional E2E tests

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

logaretm commented Oct 15, 2026 •

edited

Loading

github-actions Bot commented Oct 15, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading