Repository navigation
fix(core): Report actual item count in client reports of envelope send failures - #25185
Merged
Merged
Conversation
Lms24
changed the title
Contributor
size-limit report 📦
|
…elopes When sending an envelope failed, each item was recorded with quantity 1. Span, log and metric containers now report their item_count, and transactions also report spans.length + 1 dropped spans. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
fix/client-report-envelope-loss-quantity
branch
from
October 9, 2026 10:15
2053a20 to
3de69e6
Compare
Lms24
marked this pull request as ready for review
October 9, 2026 10:15
chargome
approved these changes
Oct 9, 2026
chargome
left a comment
chargome
left a comment
Member
There was a problem hiding this comment.
Nice! Thanks for implementing
Lms24
enabled auto-merge (squash)
October 9, 2026 10:50
Lms24
added a commit
that referenced
this pull request
Oct 9, 2026
Realized a second after merging #25185 that the report logic can be simplified to save a few bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending an envelope fails (network error, 413, or a full buffer), the transport recorded every item with quantity 1. This undercounts span, log and metric discard quantities. Same for transactions that should also report
spancounts. Containers now report theiritem_count, and transactions also reportspans.length + 1spanoutcomes, matching how the client counts dropped transactions inbeforeSend.For transactions, we also record
spanoutcomes on envelope send failures, analogously to what #25006 adds to other discard reasons