Repository navigation
test(node): Port MySQL integration tests to span streaming - #25148
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
Contributor
size-limit report 📦
|
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
marked this pull request as ready for review
October 8, 2026 09:40
nicohrubec
requested review from
JPeer264,
andreiborza and
isaacs
and removed request for
a team
October 8, 2026 09:40
JPeer264
approved these changes
Oct 8, 2026
| 'db.system.name': 'mysql', | ||
| 'db.user': 'root', | ||
| status: 'error', | ||
| attributes: expect.objectContaining({ |
Member
There was a problem hiding this comment.
l: Would be nice to be more explicit on the attributes and make it without expect.objectContaining. Like we have suggested in the /write-tests skill
Member
Author
There was a problem hiding this comment.
I swapped a few across the PRs where we could swap smaller objects for exact matches but will keep this mostly to 1:1 migrations
Co-Authored-By: GPT-6 <codex@openai.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port MySQL and MySQL2 diagnostics-channel tests to default span streaming. Keep the original MySQL2 suite static for transaction coverage.
Part of #24137