Skip to content

chore: Update comments related to span links with latest info #25135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s1gr1d wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: Update comments related to span links with latest info #25135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/browser/src/tracing/linkedTraces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ export function addPreviousTraceSpanLink(
},
});

// TODO(v12): Remove this once the Sentry trace view finds linked traces via span links. EAP stores
// span links, but the trace view still reads this attribute to navigate to the previous/next trace.
// TODO(v12): Remove once EAP can filter span links by type. The Sentry trace view searches this attribute to find the NEXT trace.
// Sentry 26.9 and older also read it to find the PREVIOUS trace. Newer versions read the span link.
span.setAttribute(
PREVIOUS_TRACE_TMP_SPAN_ATTRIBUTE,
`${previousTraceSpanCtx.traceId}-${previousTraceSpanCtx.spanId}-${
Expand Down
6 changes: 3 additions & 3 deletions packages/cloudflare/src/wrapMethodWithSentry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,9 @@ export function wrapMethodWithSentry<T extends OriginalMethod>(

if (storedContext) {
span.addLinks(buildSpanLinks(storedContext));
// TODO(v12): Remove this once the Sentry trace view finds linked traces via span links.
// EAP stores span links, but the trace view still reads this attribute to navigate to the
// previous/next trace.

// TODO(v12): Remove once EAP can filter span links by type. The Sentry trace view searches this attribute to find the NEXT trace.
// Sentry 26.9 and older also read it to find the PREVIOUS trace. Newer versions read the span link.
const sampledFlag = storedContext.sampled ? '1' : '0';
span.setAttribute(
'sentry.previous_trace',
Expand Down
Loading