Repository navigation
Conversation
…d their spans Streamed spans already carry `sentry.trace_lifecycle: 'stream'`. Set the `static` counterpart on the transaction's trace context and on every child span when a root span is converted to a transaction event. The attribute is added to copies of the span data so it doesn't leak onto the live spans. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 25f7d12. Configure here.
Contributor
size-limit report 📦
|
…heir spans Update exact-match assertions on transaction trace data and child span data across unit, integration, Playwright and E2E tests, and use the `SENTRY_TRACE_LIFECYCLE` constant where `@sentry/conventions` is available. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…AGENTS.md Mirrors the existing BUGBOT.md rule so agents use the conventions constants instead of string literals for attribute names and span ops, including in tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
|
Honestly not wort to merge this. For a complete picture we already have to check for the absence of this attribute, so adding it now kinda feels like making these queries harder, while also increasing the bundle size. I'm gonna close for now. We can always reopen when we find a use case why we'd need the attribute specifically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamed spans already carry
sentry.trace_lifecycle: 'stream'. This sets thestaticcounterpart on the transaction (its trace context) and on every child span when a root span is converted to a transaction event.