Repository navigation
Conversation
Lms24
added this pull request to stack #24904
October 6, 2026 09:58
Lms24
force-pushed
the
lms/feat-browser-page-lifecycle-drift-checks
branch
from
October 6, 2026 10:01
cee645a to
d39c98a
Compare
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d39c98a. Configure here.
Lms24
force-pushed
the
lms/feat-browser-page-lifecycle-drift-checks
branch
from
October 6, 2026 10:12
d39c98a to
670fcc8
Compare
Lms24
changed the title
Lms24
force-pushed
the
lms/feat-browser-page-lifecycle-drift-checks
branch
2 times, most recently
from
October 6, 2026 17:24
c8aff48 to
91258cb
Compare
Lms24
force-pushed
the
lms/feat-browser-page-lifecycle-drift-checks
branch
2 times, most recently
from
October 7, 2026 08:48
e86377c to
f166a90
Compare
Lms24
force-pushed
the
lms/feat-browser-page-lifecycle-drift-checks
branch
from
October 7, 2026 09:23
f166a90 to
e8cefdc
Compare
Lms24
force-pushed
the
lms/feat-browser-page-lifecycle-drift-checks
branch
from
October 7, 2026 11:58
e8cefdc to
e57d8b4
Compare
Lms24
marked this pull request as ready for review
October 7, 2026 12:00
Lms24
requested review from
logaretm and
msonnb
and removed request for
a team
October 7, 2026 12:00
msonnb
approved these changes
Oct 7, 2026
Also check on `freeze`/`resume` (Chromium only) and `pagehide`/`pageshow` (back/forward cache). This makes the time origin correction happen at the pause, not at the next regular timestamp call. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/feat-browser-page-lifecycle-drift-checks
branch
from
October 7, 2026 15:02
e57d8b4 to
c70799b
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
170
to
178
| } | ||
|
|
||
| // Pages restored from the back/forward cache were paused while they were cached. | ||
| WINDOW.addEventListener?.('pagehide', () => timestampInSeconds()); | ||
| WINDOW.addEventListener?.('pageshow', () => timestampInSeconds()); | ||
|
|
||
| if (userInfo) { | ||
| this.on('beforeSendSession', addAutoIpAddressToSession); | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: New event listeners for freeze, resume, pagehide, and pageshow are not cleaned up when a BrowserClient is destroyed, causing a memory leak.
Severity: MEDIUM
Suggested Fix
Implement a cleanup mechanism in the BrowserClient. The client should track the listeners it adds. A close() or dispose() method should be implemented or overridden to remove these event listeners from the global objects when the client is destroyed, preventing old client instances from being retained in memory.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/browser/src/client.ts#L170-L178
Potential issue: The `BrowserClient` adds global event listeners for `freeze`, `resume`,
`pagehide`, and `pageshow`. However, there is no corresponding cleanup logic to remove
these listeners when a client instance is no longer needed. If multiple `BrowserClient`
instances are created over an application's lifecycle, such as during hot-reloading, in
test suites, or by calling `Sentry.init()` multiple times, old client instances and
their closures will be retained in memory. This leads to a memory leak, as the new
listeners introduced in this change are not removed upon client destruction.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
There was a problem hiding this comment.
l: Should be easy to cleanup, no?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23054, from this review comment. Besides
visibilitychange, we now also check for clock drift onfreeze/resume(TIL) andpagehide/pageshow. This way the time origin is corrected right at the emissions, not at the next regular timestamp call.freezeandresumeonly fire in Chromium. Other browsers never fire them, so the listeners do nothing there.