fix(v10/core): Apply dataCollection.urlQueryParams to collected URLs and query strings - #24572
Merged
Merged
Conversation
Member
Author
|
bugbot run |
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…l spans and SvelteKit root spans Addresses review feedback: the OTel exporter rebuilt `http.query` from the raw span URL, and the SvelteKit handle copied the kit root span URL into `url.full` unfiltered. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9f72550. Configure here.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ery` unchanged v10 call sites assigned `URL.search` verbatim, so a query-less URL emitted `url.query: ''`. Returning `undefined` for empty input dropped the attribute and changed the wire shape. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chargome
marked this pull request as ready for review
September 22, 2026 09:08
chargome
requested review from
isaacs,
logaretm,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team
September 22, 2026 09:08
s1gr1d
approved these changes
Sep 22, 2026
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #23060, #23061, #23143, and the URL-query part of #22853
dataCollection.urlQueryParamsshipped on v10, but it was never wired to the URL fields, sorequest.url,request.query_string,url.full,url.queryand their legacy aliases were sent unfiltered. The wiring only landed ondevelop, after the v10 branch was cut.Differences to the original PRs
requestdata.tsquery-string filtering and thefilterQueryParamsrewrite it depends on are included. The v11 default changes, theincluderesolution rewrite, event cookie/header filtering, the browserhttpclientchanges and the MIGRATION notes are left out, as they are breaking or out of scope.url.full/url.query, v10 still writeshttp.url,http.query,http.targetandurl; these are now filtered instead of renamed. Tests assert on the v10 names.filterCollectedUrlQuerypreserves a leading?, because v10 recordsURL.searchverbatim inhttp.query/url.query.http.urlin the core and node-core http server spans, core fetch, browser fetch/XHR).google-cloud-http: only the span-name query stripping is kept; v10 never seturl.fullthere.nitro: unchanged, sincegetHttpSpanDetailsFromUrlObjectalready falls back togetClient().node-core, where that code sits on v10.wrapApiHandlerWithSentry, Remixhttp.url(tracing channel and vendored instrumentation), and Emberurl.full.