Conversation
Porting an op to low-cardinality names silently drops information: Relay re-derives descriptions from a separate, much shorter set of templates than the name rules, and for several ops (`function` has one template and no fallback) it cannot rebuild the name the span gave up. Document that check, and when to set `sentry.description` locally instead. Also widen the enumeration step. Its grep only matched string-literal ops, so it missed every site using the constant from `@sentry/conventions/op` - which is nearly all of them - as well as ops that arrive through a wrapper option, a helper return value or a parameter default. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting an op to low-cardinality names silently drops information, and the skill never said so. Relay re-derives descriptions from a separate, much shorter set of templates than the name rules —
functionhas exactly one,{{code.function.name}}, with no fallback — so for most ops it cannot rebuild the name the span gave up. The skill now walks that check and says when to setsentry.descriptionlocally instead, which is what the react-router and tanstackstart ports ended up doing.Also widens the enumeration step, which is how this got missed in the first place: its grep only matched string-literal ops, so it skipped every site using the constant from
@sentry/conventions/op(nearly all of them), plus ops arriving through a wrapper option, a helper return value, or a parameter default. Drop that second commit-worth of changes if you'd rather keep this PR to the description guidance.🤖 Generated with Claude Code