Skip to content

perf(android): [SDK Overhead Reduction 4] Use default timezone directly #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adinauer wants to merge 1 commit into
base: perf/sdk-overhead-reduction
Choose a base branch
from
+10 −11
Draft

perf(android): [SDK Overhead Reduction 4] Use default timezone directly #5587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions sentry-android-core/src/main/java/io/sentry/android/core/DeviceInfoUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import android.os.BatteryManager;
import android.os.Build;
import android.os.Environment;
import android.os.LocaleList;
import android.os.StatFs;
import android.os.SystemClock;
import android.util.DisplayMetrics;
Expand All @@ -25,7 +24,6 @@
import io.sentry.protocol.OperatingSystem;
import io.sentry.util.AutoClosableReentrantLock;
import java.io.File;
import java.util.Calendar;
import java.util.Collections;
import java.util.Date;
import java.util.List;
Expand Down Expand Up @@ -254,17 +252,9 @@ private void setDeviceIO(
}
}

@SuppressWarnings("NewApi")
@NotNull
private TimeZone getTimeZone() {
if (buildInfoProvider.getSdkInfoVersion() >= Build.VERSION_CODES.N) {
LocaleList locales = context.getResources().getConfiguration().getLocales();
if (!locales.isEmpty()) {
Locale locale = locales.get(0);
return Calendar.getInstance(locale).getTimeZone();
}
}
return Calendar.getInstance().getTimeZone();
return TimeZone.getDefault();
}

@SuppressWarnings("JdkObsolete")
Expand Down
9 changes: 9 additions & 0 deletions sentry-android-core/src/test/java/io/sentry/android/core/DeviceInfoUtilTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import android.os.BatteryManager
import androidx.test.core.app.ApplicationProvider
import androidx.test.ext.junit.runners.AndroidJUnit4
import io.sentry.android.core.internal.util.CpuInfoUtils
import java.util.TimeZone
import kotlin.test.BeforeTest
import kotlin.test.Test
import kotlin.test.assertEquals
Expand Down Expand Up @@ -47,6 +48,14 @@ class DeviceInfoUtilTest {
assertNotNull(deviceInfo.memorySize)
}

@Test
fun `sets default timezone`() {
val deviceInfoUtil = DeviceInfoUtil.getInstance(context, SentryAndroidOptions())
val deviceInfo = deviceInfoUtil.collectDeviceInformation(false, false)

assertEquals(TimeZone.getDefault(), deviceInfo.timezone)
}

@Test
fun `does include cpu data`() {
CpuInfoUtils.getInstance().setCpuMaxFrequencies(listOf(1024))
Expand Down
Loading