Skip to content

chore(deps): update Gradle to v9.2.1 #4913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

chore(deps): update Gradle to v9.2.1 #4913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@
- Discard envelopes on `4xx` and `5xx` response ([#4950](https://github.com/getsentry/sentry-java/pull/4950))
- This aims to not overwhelm Sentry after an outage or load shedding (including HTTP 429) where too many events are sent at once

### Dependencies

- Bump Gradle from v8.14.3 to v9.2.1 ([#4913](https://github.com/getsentry/sentry-java/pull/4913))
- [changelog](https://github.com/gradle/gradle/blob/master/CHANGELOG.md#v921)
- [diff](https://github.com/gradle/gradle/compare/v8.14.3...v9.2.1)

## 8.29.0

### Fixes
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.1-bin.zip
Copy link

@cursor cursor bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Gradle wrapper JAR not updated with version bump

The distributionUrl was updated to Gradle 9.2.1, but the gradle-wrapper.jar binary file was not updated. When the wrapper distribution URL is changed, the wrapper JAR should also be regenerated or updated to ensure compatibility. This mismatch could cause build failures or unexpected behavior when developers or CI/CD systems use the wrapper.

Fix in Cursor Fix in Web

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

Copy link

@sentry sentry bot Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The io.sentry.javadoc.gradle.kts plugin uses setDestinationDir(), an API removed in the updated Gradle version, which will cause the build to fail.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The pull request updates the Gradle version to 9.2.1. However, a custom Gradle plugin, io.sentry.javadoc.gradle.kts, continues to use the setDestinationDir(File) method on the Javadoc task. This method was removed in Gradle 9.0.0 in favor of a modern property-based API. Since this plugin is applied to over 40 modules, any attempt to build the project will result in a NoSuchMethodError, causing a complete and widespread build failure.

💡 Suggested Fix

In build-logic/src/main/kotlin/io.sentry.javadoc.gradle.kts, update the Javadoc task configuration to use the modern property API. Replace setDestinationDir(...) with destinationDirectory.set(project.layout.buildDirectory.dir("docs/javadoc")).

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: gradle/wrapper/gradle-wrapper.properties#L3

Potential issue: The pull request updates the Gradle version to 9.2.1. However, a custom
Gradle plugin, `io.sentry.javadoc.gradle.kts`, continues to use the
`setDestinationDir(File)` method on the `Javadoc` task. This method was removed in
Gradle 9.0.0 in favor of a modern property-based API. Since this plugin is applied to
over 40 modules, any attempt to build the project will result in a `NoSuchMethodError`,
causing a complete and widespread build failure.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7641097

networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
Loading