Skip to content

docs(self-hosted): use new taskbroker config format in scaling examples#18550

Merged
aldy505 merged 2 commits into
masterfrom
markusunterwaditzer/taskbroker-docs-new-config-format
Jun 25, 2026
Merged

docs(self-hosted): use new taskbroker config format in scaling examples#18550
aldy505 merged 2 commits into
masterfrom
markusunterwaditzer/taskbroker-docs-new-config-format

Conversation

@untitaker

Copy link
Copy Markdown
Member

Migrate the taskbroker scaling examples to the new config-file format (kafka_topics/kafka_clusters via a mounted config.yml), replacing the deprecated TASKBROKER_KAFKA_* env-var config.

The config format migration was announced in self-hosted 26.6.0.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment Jun 25, 2026 10:12am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
sentry-docs Ignored Ignored Preview Jun 25, 2026 10:12am

Request Review

TASKBROKER_KAFKA_CLUSTERS__DEFAULT__ADDRESS: "kafka:9092"
TASKBROKER_DB_PATH: "/opt/sqlite/taskbroker-activations.sqlite"
TASKBROKER_STATSD_ADDR: ${STATSD_ADDR:-127.0.0.1:8125}
command: /opt/taskbroker -c /etc/taskbroker/config.yml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The documentation for scaling brokers is missing instructions to create the taskbroker/config.yml file, which will cause container startup failures for the taskbroker-beta and taskbroker-charlie services.
Severity: HIGH

Suggested Fix

Add a section that instructs users on how to create the taskbroker/config.yml file, including its necessary content. This should be similar to the instructions already provided for taskbroker/config.ingest.yml in the "Separate Ingest Workers" section.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: develop-docs/self-hosted/tasks.mdx#L77

Potential issue: The documentation for scaling brokers instructs users to configure the
`taskbroker-beta` and `taskbroker-charlie` services to use a configuration file at
`/etc/taskbroker/config.yml`. The services mount a local `./taskbroker` directory to
`/etc/taskbroker`. However, the documentation omits the step of creating the
`taskbroker/config.yml` file. Users following these instructions will encounter
container startup failures because the taskbroker binary is explicitly told to use a
config file that does not exist. This is inconsistent with the "Separate Ingest Workers"
section, which correctly documents the creation of its required configuration file.

Also affects:

  • develop-docs/self-hosted/tasks.mdx:93

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong, but it's a bit confusing without context, updated

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@aldy505 aldy505 merged commit a97bbb5 into master Jun 25, 2026
21 checks passed
@aldy505 aldy505 deleted the markusunterwaditzer/taskbroker-docs-new-config-format branch June 25, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants