fix(typos): allow pluralized SQL keywords INSERTs and SELECTs#18520
Merged
Conversation
The typos checker splits 'INSERTs' and 'SELECTs' into stems 'INSER' and 'SELEC', then flags them as misspellings. These are valid pluralized SQL keywords used in technical documentation (e.g., 'ClickHouse INSERTs'). This unblocks #17782.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sergical
approved these changes
Jun 23, 2026
sfanahata
added a commit
that referenced
this pull request
Jun 23, 2026
## Summary Follow-up to #18520. The full-word entries `INSERTs`/`SELECTs` added in that PR are not sufficient because `crate-ci/typos` splits mixed-case plurals at the case boundary (`INSER` + `Ts`) and checks each subword independently. The stems `INSER` and `SELEC` must also be allowlisted. This follows the same pattern already used in the config: - `STARTD` — stem of `MIGRATED_GETTING_STARTD_DOCS` - `ERRO` — stem of `ERRORs` ## Motivation Unblocks #17782, which is still blocked by the `Check Typos` CI check after #18520 was merged. Co-authored-by: Shannon Anahata <shannonanahata@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
crate-ci/typoschecker splitsINSERTsandSELECTsinto stemsINSERandSELEC, then flags them as misspellings ofINSERTandSELECT. These are valid pluralized SQL keywords used in technical documentation (e.g., "ClickHouse INSERTs").This adds both words to the
[default.extend-words]allowlist in_typos.toml, following the same pattern already used forDSNs,SDKs,APIs, etc.Motivation
Unblocks #17782, which is blocked by the required
Check TyposCI check due to these false positives on line 89 ofdevelop-docs/self-hosted/troubleshooting/snuba.mdx.