Skip to content

Fix Dependabot alerts#17699

Open
a-hariti wants to merge 14 commits into
masterfrom
fix-dependabot-alerts-high
Open

Fix Dependabot alerts#17699
a-hariti wants to merge 14 commits into
masterfrom
fix-dependabot-alerts-high

Conversation

@a-hariti

@a-hariti a-hariti commented May 9, 2026

Copy link
Copy Markdown
Collaborator

Fixes high-severity Dependabot alerts:

Also fixes medium-severity Dependabot alerts:

@vercel

vercel Bot commented May 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment May 11, 2026 3:13pm
sentry-docs Ready Ready Preview, Comment May 11, 2026 3:13pm

Request Review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7881d5d. Configure here.

Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment on lines +180 to +186
"minimatch": "^9.0.0",
"fast-uri": "3.1.2",
"vite": "7.3.2",
"fast-xml-builder": "1.1.7",
"lodash-es": "4.18.1",
"picomatch@<3.0.0": "2.3.2",
"picomatch@>=4.0.0 <4.0.4": "4.0.4"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather not solve this with overrides if possible, but bump the transitive dep chain

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how much we can avoid this, will take a look

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right @chargome, most of them were fixable in the lockfile through the pnpm cli

please take another look 👀

Comment thread package.json
@sfanahata

Copy link
Copy Markdown
Contributor

Superseded by #17998, which is a fresh branch from master that addresses all remaining open alerts (plus 2 new ones: #324 uuid, #325 js-cookie) without the merge conflicts. Followed @chargome's feedback to prefer lockfile updates over overrides where possible — only using overrides where upstream packages haven't released fixes.

Closing in favor of #17998.

sfanahata added a commit that referenced this pull request Jun 24, 2026
## DESCRIBE YOUR PR

Resolves open Dependabot security alerts via dependency bumps, lockfile
updates, and targeted pnpm overrides. Supersedes #17699.

### Critical (1):
- [Alert
329](https://github.com/getsentry/sentry-docs/security/dependabot/329)
**shell-quote**: command injection → override `shell-quote: ^1.8.4`

### High-severity (5):
- [Alert
325](https://github.com/getsentry/sentry-docs/security/dependabot/325)
**js-cookie**: prototype hijack → bumped `^3.0.5` → `^3.0.7`
- [Alert
303](https://github.com/getsentry/sentry-docs/security/dependabot/303)
**fast-xml-builder** → override `fast-xml-parser: ^5.7.0`
- [Alert
343](https://github.com/getsentry/sentry-docs/security/dependabot/343)
**vite**: → added as devDependency at `^7.3.5`
- [Alerts 346,
347](https://github.com/getsentry/sentry-docs/security/dependabot/346)
**form-data** → override `form-data: ^4.0.6`

### Medium-severity (20+):
- [Alerts 291–298, 333–339,
348–357](https://github.com/getsentry/sentry-docs/security/dependabot)
**dompurify** (many): XSS bypasses → bumped `3.3.2` → `3.4.11` (direct
dep + override)
- [Alert
342](https://github.com/getsentry/sentry-docs/security/dependabot/342)
**js-yaml** → bumped `^4.1.0` → `^4.2.0`
- [Alert
324](https://github.com/getsentry/sentry-docs/security/dependabot/324)
**uuid** → override `uuid: ^11.1.1`
- [Alert
300](https://github.com/getsentry/sentry-docs/security/dependabot/300)
**fast-xml-parser** → override `fast-xml-parser: ^5.7.0`
- [Alert
301](https://github.com/getsentry/sentry-docs/security/dependabot/301)
**postcss** → override `postcss: ^8.5.10` (next.js bundles 8.4.31)
- [Alert
344](https://github.com/getsentry/sentry-docs/security/dependabot/344)
**launch-editor** → override `launch-editor: ^2.14.1`
- [Alerts 287–289,
345](https://github.com/getsentry/sentry-docs/security/dependabot/287)
**vite** (4 alerts) → `^7.3.5` devDep + override
- [Alerts
359–360](https://github.com/getsentry/sentry-docs/security/dependabot/359)
**undici** → bumped override `^6.24.0` → `^6.27.0`
- [Alert
284](https://github.com/getsentry/sentry-docs/security/dependabot/284)
**brace-expansion** → lockfile update to 2.1.1
- [Alerts
277–278](https://github.com/getsentry/sentry-docs/security/dependabot/277)
**yaml** → lockfile update to 1.10.3 / 2.9.0

### Not addressed in this PR:
- [Alert
355](https://github.com/getsentry/sentry-docs/security/dependabot/355)
**@opentelemetry/core** (medium) — needs `@sentry/nextjs` to bump its
OpenTelemetry deps
- [Alert
331](https://github.com/getsentry/sentry-docs/security/dependabot/331)
**esbuild** (low) — already at `^0.28.1` as direct dep; alert may be for
transitive 0.27.x
- [Alert
341](https://github.com/getsentry/sentry-docs/security/dependabot/341)
**@babel/core** (low) — needs upstream package updates

### Cleanup:
- Removed `@types/dompurify` from devDependencies and pnpm overrides —
dompurify 3.x ships its own TypeScript definitions, and
`@types/dompurify` is [officially deprecated as a
stub](https://www.npmjs.com/package/@types/dompurify)

### Override justifications:
| Override | Why not a direct bump? |
|----------|----------------------|
| `dompurify: 3.4.11` | `mermaid` and `@sentry-internal/global-search`
pull it transitively |
| `fast-xml-parser: ^5.7.0` | `@google-cloud/storage` depends on old
version |
| `postcss: ^8.5.10` | Next.js 15.5.18 bundles postcss 8.4.31 internally
|
| `uuid: ^11.1.1` | No 8.x/9.x patch exists; API-compatible; 3 of 4
consumers dropped uuid in latest |
| `shell-quote: ^1.8.4` | Transitive via `launch-editor` |
| `launch-editor: ^2.14.1` | Transitive via vite/Next.js dev server |
| `form-data: ^4.0.6` | Transitive via `jsdom` (test environment) |
| `undici: ^6.27.0` | Bumped existing override from `^6.24.0` |
| `vite: ^7.3.5` | Also added as devDep since override alone didn't
resolve it |

## IS YOUR CHANGE URGENT?
- [x] None: Not urgent, can wait up to 1 week+

## PRE-MERGE CHECKLIST
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

Co-authored-by: Shannon Anahata <shannonanahata@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants