Skip to content

build(deps): Skip NDK sample during Renovate lockfile updates #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
runningcode wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

build(deps): Skip NDK sample during Renovate lockfile updates #1368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,19 @@ include(":examples:android-gradle")

include(":examples:android-gradle-kts")

include(":examples:android-ndk")
// Configuring this sample makes AGP download and set up the NDK, which isn't available when
// Renovate regenerates the dependency lockfile/verification metadata and would fail the run.
// The sample is never needed to resolve dependencies, so skip it on those runs. Renovate
// always invokes Gradle with --write-locks/--update-locks and --dependency-verification
// lenient; normal dev and CI builds don't, so they still build the sample.
val isDependencyResolutionRun =
startParameter.isWriteDependencyLocks ||
startParameter.lockedDependenciesToUpdate.isNotEmpty() ||
startParameter.dependencyVerificationMode ==
org.gradle.api.artifacts.verification.DependencyVerificationMode.LENIENT
if (!isDependencyResolutionRun) {
include(":examples:android-ndk")
}

include(":examples:android-instrumentation-sample")

Expand Down
Loading