ci: cap code files at 1,000 lines#1060
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dcramer
marked this pull request as ready for review
July 26, 2026 23:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code files now fail the normal lint path when they exceed 1,000 lines unless they have an explicit, reasoned exception. The checker also rejects stale exceptions, runs its own unit tests, and records the current oversized-file debt so new monoliths cannot slip in unnoticed.
The existing 1,901-line GitHub plugin entry point is split into plugin composition and egress policy, credential support, and Git setup while preserving the package's public exports and behavior. The repository guidance now also asks shared exports to remain easy to find and documents important intentionally absent behavior.
The GitHub package builds, typechecks, and lints successfully, and its 102 targeted plugin tests pass. Review should focus on the exception list and the behavior-preserving GitHub module split.