Skip to content

feat: Add import/export device settings utils for PS5#43

Merged
tustanivsky merged 4 commits into
mainfrom
feat/ps-settings
Mar 3, 2026
Merged

feat: Add import/export device settings utils for PS5#43
tustanivsky merged 4 commits into
mainfrom
feat/ps-settings

Conversation

@tustanivsky

@tustanivsky tustanivsky commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

This PR adds two new public functions (Export-DeviceSettings and Import-DeviceSettings) that expose the prospero-ctrl settings export and settings import commands for connected PlayStation 5 devkits.

Key changes:

  • Add settingsimport command to PlayStation5Provider
  • Add ExportSettings() and ImportSettings() methods to the base DeviceProvider class
  • Add Export-DeviceSettings and Import-DeviceSettings public functions
  • Register both functions in the module manifest

Related items:

#skip-changelog

@tustanivsky
tustanivsky marked this pull request as ready for review March 3, 2026 07:38

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Duplicate settings export logic bypasses new wrapper
    • Replaced direct InvokeCommand('settingsexport') call with ExportSettings() method in PlayStation5Provider.GetDiagnostics().

Create PR

Or push these changes by commenting:

@cursor push 844694767a
Preview (844694767a)
diff --git a/app-runner/Private/DeviceProviders/PlayStation5Provider.ps1 b/app-runner/Private/DeviceProviders/PlayStation5Provider.ps1
--- a/app-runner/Private/DeviceProviders/PlayStation5Provider.ps1
+++ b/app-runner/Private/DeviceProviders/PlayStation5Provider.ps1
@@ -191,7 +191,7 @@
         # Run prospero-ctrl settings export
         try {
             $settingsFile = Join-Path $OutputDirectory "$datePrefix-settings.xml"
-            $this.InvokeCommand('settingsexport', @($settingsFile))
+            $this.ExportSettings($settingsFile)
             $results.Files += $settingsFile
             Write-Debug "Settings exported to: $settingsFile"
         } catch {
This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Comment thread app-runner/Private/DeviceProviders/PlayStation5Provider.ps1
Comment thread app-runner/Private/DeviceProviders/DeviceProvider.ps1

@JoshuaMoelans JoshuaMoelans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm!

@tustanivsky
tustanivsky merged commit 3650b12 into main Mar 3, 2026
16 checks passed
@tustanivsky
tustanivsky deleted the feat/ps-settings branch March 4, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants