Add prompt deep links for new workspaces - #4189
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
| Filename | Overview |
|---|---|
| packages/app/src/screens/new-workspace-screen.tsx | Seeds the composer after draft hydration and initializes terminal prompt text from the deep-link query. |
| packages/desktop/src/main.ts | Routes new-workspace links during cold starts and subsequent desktop invocations while redacting prompt diagnostics. |
| packages/website/src/routes/new.tsx | Registers the website endpoint that redirects new-workspace requests to the desktop app scheme. |
| packages/app/e2e/browser/new-workspace-deep-link.spec.ts | Verifies the user-visible deep-link prefill behavior through a focused domain helper. |
Reviews (10): Last reviewed commit: "Add prompt deep links for new workspaces" | Re-trigger Greptile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f3405bd56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
541142f to
da2ea28
Compare
|
Plugin-initiated prefill: routing works, I'm building a plugin whose sidebar lists scheduled tasks from an internal platform. Each row should have a button that opens a new session prefilled with that task's config and recent run history, so the user can review and edit before sending. I probed this against 0.7.2 from plugin surface code, three ways:
So the in-app path already works; Why plugins need it: Two questions:
Happy to test a build. |
da2ea28 to
95b31ff
Compare
95b31ff to
11c5a49
Compare
|
Closing this feature PR. Please describe the workflow and shared need in Discussions, as described in CONTRIBUTING.md. |
|
@boudra why not have some discussion over implemented code instead of closing them outright, especially on PRs that add functionality broadly available in similar tools and expected. In discussions there are lots of requests without response so it gets buried - here at least we can talk over an implementation |
Linked issue
Closes #
Type of change
Reasoning
New-workspace links could select a host, project, directory, and draft, but users still had to copy and paste the task they wanted to start.
This change adds a
qquery parameter that prefills the new workspace composer without submitting it. Bothpaseo://new?q=...andhttps://paseo.sh/new?q=...are supported, allowing users to review or edit the prepared prompt before starting their workspace.Goals
/newqquery parameter.qin bothpaseo://newlinks andhttps://paseo.sh/newredirects.serverId,dir,name,projectId, anddraftIdparameters.qfrom desktop launch-argument diagnostic logs.Non-goals
qis an ordinary query parameter./newparameters.QA
Requester verification:
Focused unit tests:
Real-browser regression:
The Playwright test:
/newwithserverId,name=TEst, and an encoded multilineq.6767is explicitly blocked by the fixture.Website redirect verification:
Additional checks:
No visual layout changes are intended; the browser test verifies the changed composer behavior directly.
Checklist
npm run typecheckpassesnpm run lintpassesnpm run formatpasses