Add a trigger for pull request head updates - #79
Draft
thaning0 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related discussion: getpaseo/paseo#3924
Note
This is a draft for feedback on the workflow, event semantics, and public event name. A companion public-docs PR will follow once those points are agreed.
Hub workflows can subscribe to the proposed
github.pull_request_updatedevent when GitHub deliverspull_request.synchronize. Other pull request actions do not match this semantic event, and existing GitHub trigger behavior remains unchanged.Goals
github.pull_request_updatedas a semantic GitHub trigger.pull_request.synchronizedeliveries as pull request head updates.Non-goals
Why
The raw
github.pull_requestsource is already routed to the GitHub trigger provider. The semantic classifier handles opened and labeled pull requests, but does not represent thesynchronizeaction used for pull request head updates.This change adds that missing semantic classification without changing the underlying webhook boundary.
Documentation
The companion public-docs PR is pending agreement on the event semantics and name in the linked discussion.
Verification
npm run release:check: passed.Risk surface
Limited to GitHub pull request semantic classification and the corresponding activity summary. Regression tests verify that
synchronizematches the proposed event while metadata edits do not.