feat: allow GitHub team trigger filters - #54
Conversation
c29fe1a to
390fda6
Compare
# Conflicts: # src/triggers/github/match.test.ts # src/triggers/github/match.ts # src/triggers/github/provider.test.ts
# Conflicts: # src/triggers/github/provider.test.ts
…rs' into add-limited-llm-access-for-hub-routing # Conflicts: # src/triggers/github/match.test.ts # src/triggers/github/match.ts # src/triggers/github/provider.test.ts
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d224667c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0feb1e1a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
filters.from_teamsallowlists usingorganization/team-slugWhy
Workflow authors should be able to authorize a GitHub team without maintaining a list of every member login.
User impact
from_teamsis GitHub-only and combines withfrom_usersas an OR allowlist. It requires the GitHub App Members permission with read access; if membership cannot be established, Hub does not start a run.Canonical documentation
filters.from_teams, its OR behavior withfrom_users, and the GitHub App Members read permission.Validation
npm run typechecknpm run lintnpm run format:checknpm testwas attempted; unrelated Testcontainers-based daemon and integration tests could not run because this environment has no working container runtime