Add intersects function and incremental=true #2029
Merged
lognaturel merged 2 commits intogetodk:masterfrom Feb 17, 2026
Merged
Conversation
lognaturel
force-pushed
the
intersects
branch
from
e5f29cf to
79af11b
Compare
lognaturel
force-pushed
the
intersects
branch
from
79af11b to
34dd32f
Compare
alyblenkin
approved these changes
Feb 10, 2026
alyblenkin
left a comment
alyblenkin
left a comment
There was a problem hiding this comment.
So nice to finally update these!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2021
I think it would be nice to have a dedicated tutorial as well, we can add it to the list! The goal here is to document the function and update the screenshots. I hesitated on where to document
incremental=true. I ended up only putting it withintersectsso it wouldn't be duplicated between trace and shape. I don't think it's very likely to be used with other constraints expressions but I tried to explain clearly how it could be used in case there are cases I'm not thinking of.