Skip to content

Rework the summary view to use the new widget answer components#7009

Merged
seadowg merged 30 commits intogetodk:masterfrom
grzesiek2010:new_summary_view
Feb 17, 2026
Merged

Rework the summary view to use the new widget answer components#7009
seadowg merged 30 commits intogetodk:masterfrom
grzesiek2010:new_summary_view

Conversation

@grzesiek2010
Copy link
Copy Markdown
Member

@grzesiek2010 grzesiek2010 commented Dec 30, 2025

Work towards ##6084

Why is this the best possible solution? Were any other approaches considered?

There’s nothing critical to discuss here. This change simply reworks the summary view to use shared components, which was the core of the feature.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This update reworks how answers (only answers, not regular groups, repeatable groups, or question labels) are displayed in the summary view, leveraging the recently added components from:

With this change, new components, such as the video component, should now appear in the summary view, alongside answers with icons (e.g., barcode, file).

Please test to ensure everything works correctly in this context. Additionally, verify styled answers using the guidelines here: https://docs.getodk.org/form-styling/.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 force-pushed the new_summary_view branch 6 times, most recently from 9266b68 to 56903bd Compare January 5, 2026 13:23
@grzesiek2010 grzesiek2010 marked this pull request as ready for review January 5, 2026 14:35
@grzesiek2010 grzesiek2010 requested a review from seadowg January 5, 2026 14:35
@seadowg
Copy link
Copy Markdown
Member

seadowg commented Feb 5, 2026

@grzesiek2010 looks like the fail here is just a size increase. I can't see anything significant that could have caused it though. Just more code?

Comment thread collect_app/src/androidTest/java/org/odk/collect/android/support/pages/Page.kt Outdated
Comment thread collect_app/src/androidTest/java/org/odk/collect/android/support/pages/Page.kt Outdated
@grzesiek2010 grzesiek2010 requested a review from seadowg February 6, 2026 09:10
Comment thread collect_app/build.gradle
Comment thread collect_app/src/main/java/org/odk/collect/android/widgets/QuestionWidget.java Outdated
Copy link
Copy Markdown
Member

@seadowg seadowg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grzesiek2010 grzesiek2010 requested a review from seadowg February 12, 2026 11:49
Comment thread collect_app/src/main/java/org/odk/collect/android/formhierarchy/HierarchyItem.kt Outdated
Comment thread collect_app/src/main/java/org/odk/collect/android/widgets/TextWidgetAnswer.kt Outdated
Comment thread collect_app/src/main/java/org/odk/collect/android/widgets/TextWidgetAnswer.kt Outdated
@grzesiek2010 grzesiek2010 requested a review from seadowg February 15, 2026 22:05
@seadowg seadowg merged commit 00ae167 into getodk:master Feb 17, 2026
8 checks passed
@WKobus
Copy link
Copy Markdown

WKobus commented Feb 18, 2026

Tested with success

Verified on device with Android 16

Verified cases:

@dbemke
Copy link
Copy Markdown

dbemke commented Feb 18, 2026

Tested with success

Verified on device with Android 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants