-
Notifications
You must be signed in to change notification settings - Fork 1
P-2343 Add Privy integration for multi-account user identity clustering #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
076ef6d
feat(privy): one-liner identifyPrivyUser to cluster a Privy user's wa…
claude 5d39f80
refactor(privy): address API review — safer setActive contract, smart…
claude b937acf
refactor(privy): drop core identify() API changes; solve attribution …
claude 7bdc05b
feat(privy): add identify(user, { privy: true }); drop the React hook
claude b3f8ad1
feat(privy): default attribution to user.wallet; make activeAddress o…
claude ed0006a
fix(privy): address Codex review — 4 correctness fixes
claude dbd5d3c
fix(privy): preserve current address when active wallet isn't linked
claude ab05adb
refactor(privy): root fix — clustering identifies no longer mutate ac…
claude 5c33237
docs(privy): add integration plan/status doc; fix stale activeAddress…
claude 2581432
fix(privy): reconcile chain before emitting; disambiguate dedup keys
claude 594dc71
fix(privy): size-bound the identify dedup store for many-wallet users
claude 1aab641
fix(privy): direct identifyPrivyUser() preserves the connected wallet
claude b026ba6
fix(privy): carry the DID on every clustering identify; skip sync whe…
claude 6fe2370
docs(privy): fix stale attribution docs; drop dead export
claude e8712bf
Merge remote-tracking branch 'origin/main' into claude/privy-identify…
claude bff1f02
Merge remote-tracking branch 'origin/main' into claude/privy-identify…
yosriady b9fc80b
feat(privy): parse all linked accounts; make identify dedup profile-a…
yosriady bc93e98
fix: repair broken pnpm-lock.yaml duplicated mapping keys
yosriady 7c046de
fix(privy): address review findings on dedup, cookie budget, and docs
yosriady de9256c
docs(privy): replace the plan doc with how-it-works; add successive-l…
yosriady 4292433
feat(privy): drop the { privy: true } flag; dispatch on shape
yosriady 048badf
docs(privy): cover apps with both Privy and non-Privy users
yosriady 68381c7
docs(privy): remove em dashes from prose and comments
yosriady cd19cd9
docs(privy): consolidate the two Privy docs into one
yosriady 711fd22
fix: don't burn the identify dedup entry on an excluded chain
yosriady File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an app passes an empty string from an optional user-id variable, this new nullish fallback preserves
formoEvent.user_id === ""for identify events instead of treating it as absent like the previoususerId || nullpath and theidentify()state update (if (userId)) still do. In that scenario identify payloads can be sent with a shared emptyuser_id, so keep falling back on falsy/empty payload user IDs while still preserving real Privy DIDs.Useful? React with 👍 / 👎.