menubar: one-click update for the CLI and the app together#778
Merged
Conversation
The Update badge previously replaced only the menubar (via the CLI's menubar --force installer), and the CLI banner only copied the update command to the clipboard. One click now runs the whole sequence: update the CLI in place through the package manager it was installed with (brew upgrade, or npm install -g codeburn@latest --force; the npm next to the codeburn launcher wins so nvm/volta/asdf installs update inside their own toolchain), re-read the installed version, then run the app replacement from the freshly updated CLI. No recognizable package manager surfaces the manual command instead of guessing at a mutation; a homebrew CLI without a findable brew never falls through to npm, which would create a second conflicting install. The badge now also appears for CLI-only updates, and the banner's primary action is Update now with the copyable command kept as secondary. Six resolution tests, mutation-verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Update badge replaced only the menubar and the CLI banner only copied a command to the clipboard. One click now updates both, in order: the CLI in place via the package manager it actually came from (brew upgrade, or npm install -g codeburn@latest --force, preferring the npm sitting next to the codeburn launcher so nvm/volta/asdf installs update inside their own toolchain), then the app via the existing menubar --force installer run from the freshly updated CLI. Unrecognizable installs surface the manual command instead of guessing; a homebrew CLI without a findable brew never falls through to npm. Badge shows for CLI-only updates too; banner gains an Update now action with the copyable command as secondary. Six resolution tests (mutation-verified), Swift suites green (30 XCTest + 89 Swift Testing). Ships with the next mac tag.