Fix question keyboard focus and Enter submission - #4139
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 SLOP COP 🚨 ·
new-issue-autopilotHuman comments
What was wrong
Numbered question shortcuts changed the selected answer without moving keyboard focus. The question form had no Enter handler for option answers, so pressing Enter afterward did not submit. Reproduction and root-cause report.
What changed
Focus the question container after a numbered option selection and route plain Enter on that container through the existing Next/Submit behavior. Child controls, free-text input, modifiers, composition, and disabled forms retain their existing behavior.
Two files changed: 88 additions + 3 deletions = 91 changed text lines. No dependencies, generated files, stored-data changes, or public contracts changed.
How you verified
pnpm exec turbo run test --filter=@bb/app -- src/components/thread/user-questions/QuestionForm.test.tsx: 13 tests pass after the fix, including multi-question and multi-select keyboard flows, modifier/composition guards, and free-text behavior.pnpm exec turbo run test --filter=bb-plugin-ask-user-question: 37 tests pass.pnpm exec turbo run typecheck --filter=@bb/shared-ui --filter=@bb/appandgit diff --checkpass.Fixes #4137