Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Claude provider maintenance ignored
CLAUDE_CONFIG_DIR. On macOS it always read the unsuffixedClaude Code-credentialsKeychain item, while Claude Code stores custom-profile credentials under a service suffixed with the first eight SHA-256 characters of the resolved config directory. It also read credential and account files from the default profile paths. A stale default-profile token could therefore make a working custom profile appear expired or unauthenticated, as reproduced in #3607.What changed
Provider maintenance now resolves absolute, home-relative, and home-based relative
CLAUDE_CONFIG_DIRvalues consistently. Custom profiles use their resolved directory for.credentials.jsonand.claude.json, and macOS selectsClaude Code-credentials-<hash>. The unsuffixed Keychain item remains a last fallback only when the custom service is absent and the custom credential file did not yield credentials. Default-profile paths and service names remain unchanged. Regression tests cover the custom Keychain service, account metadata, relative config paths, stale default credentials, and custom file precedence. There are no wire, CLI, guide, or protocol changes.How you verified
pnpm exec turbo run test --filter=bb-plugin-provider-claude-code --env-mode=loose(27 files, 367 tests passed)pnpm exec turbo run typecheck --filter=bb-plugin-provider-claude-code --env-mode=loosepnpm exec oxfmt --check plugins/provider-claude-code/src/bridge/provider-maintenance.ts plugins/provider-claude-code/src/bridge/provider-maintenance.credentials.test.tsgit diff --checkFixes #3607