Conversation
vznh
marked this pull request as ready for review
September 22, 2026 18:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
The aim is switching providers keeps each provider’s saved settings, and that upgrading preserves existing settings.
Looks like a huge diff - 5,041 lines come from the migration.
What was wrong
Project execution defaults were unique by project alone, so using another provider overwrote the previous provider’s saved settings. Existing-thread model recovery could also receive another provider’s model.
What changed
Store defaults by project and provider, and scope server fallback reads to the selected provider. Unscoped reads still select the last-used provider. Migration 0131 preserves existing settings and supports replay.
Use atomic monotonic timestamps instead of the issue’s proposed rowid tie-breaker so A → B → A remains correct within one millisecond. Project-list queries select only each project’s latest row.
The generated Drizzle snapshot accounts for most of the diff and changes only the defaults table’s unique key. No UI, public API, CLI, or daemon protocol changes.
How you verified
Human and agent verified together.
Fixes #3463