Conversation
…-feasibility-thr_nrnc7zf4hm
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
BB Browser tabs had three related lifecycle failures:
WebContentsView, so the old page could remain over the destination thread after navigation, especially when the destination came from More.What changed
No database schema, plugin API, SDK contract, daemon protocol, or persisted-data break.
How you verified
5f6e5f020passed all required checks.The recovery screenshots below were captured from the original recovery layer before consolidation. Fresh native screenshots from consolidated head
5f6e5f020are pending because macOS denied Screen Recording permission to the bb process running QA. User QA is pending.Before:
3f74c55c3ec5d885e233450904735d6db6e37a48· Recovery layer:0e520907ab11159ada326a776ffabcac6fb3459a· Captured at 2×After pressing Reopen tab on the recovery layer:
BB-Thread-ID: thr_qnsq6z9vs8