Conversation
Code Coverage OverviewLanguages: Ruby Ruby / code-coverage/simplecovThe overall line coverage in commit b839a2c in the Show a line coverage summary of the most impacted files.
Updated |
Contributor
Author
|
Pronto para homologação |
A 4.3.1 do active_scaffold corrigiu a montagem das opcoes do picker, que
convertia tudo em string ("preserving boolean and integer values"). O
pt-BR do SAPOS declara um inteiro, firstDay, que o spec ja prendia, e
dois booleanos, isRTL e showMonthAfterYear, que ninguem olhava.
Importa porque em JavaScript a string "false" e verdadeira: com isRTL
virando "false" o calendario abre da direita para a esquerda. O valor vai
interpolado num asset, entao a regressao nao aparece na suite nem quebra
o precompile -- so a tela.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jeu1BMvAGSfZnvXnAHCbzj
Ate a 4.2 a conversao de valor gravado em rotulo vivia dentro de format_column_value, para form_ui :select e :radio com options declaradas. A 4.3.0 tirou o bloco de la e o transformou em list UI proprio, alcancado por list_ui -- que cai para form_ui, como show_ui cai para list_ui. O SAPOS nao declara list_ui nem show_ui em lugar nenhum, entao o conjunto de colunas atingido e o mesmo e a refatoracao deveria ser invisivel na tela. Nenhum teste media isso. As tres colunas cujas options sao pares [rotulo, valor] -- students.sex, professors.sex e professors.civil_status -- nunca tiveram cobertura que olhasse o texto exibido, e a troca de caminho passaria sem alarme se derrubasse a conversao. O contraponto em coluna cujo rotulo e igual ao valor evita que uma conversao que devolvesse sempre o primeiro rotulo passe despercebida. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jeu1BMvAGSfZnvXnAHCbzj
O initializer 'active_scaffold.testing', novo na 4.3, chama RSpec.configure quando defined?(RSpec). A guarda e frouxa: o Bundler.require do grupo :test define o modulo, mas o metodo vem do rspec-core, que so e carregado pelo binario do rspec. Sem ele o initialize! estoura e derruba db:schema:load, db:migrate e afins -- foi o que quebrou o CI. Dentro do processo do rspec isso e inmensuravel: ali o rspec-core sempre esta carregado e a linha do config/application.rb parece inocua. Dai o subprocesso, que custa segundos. Sem ele, a regressao so apareceria no CI, depois do commit, disfarcada de falha do db:schema:load. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jeu1BMvAGSfZnvXnAHCbzj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.