fix(citations): accept string in journal volume and issue fields#33
Merged
Conversation
Some references describe compound issues (e.g. conoscope.yaml cites Acta Cryst 'Section A, Issues 1–4'), which cannot be represented as a single integer. Relaxes the schema to accept either int or string for both volume and issue. The format library already coerces to string for display so no downstream changes are needed. Fixes the build-time Astro content schema error blocking npm run build after Phase 3 citation merges.
|
🚀 Preview deployed to: https://f28efe39.gemmology-dev.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 introduced a journal reference in
equipment/conoscope.yamlciting Acta Crystallographica Section A, Issues 1–4 — a real compound-issue value that cannot be represented as a single integer.Relaxes the journal reference schema in
src/content/config.tsto accept eitherz.number().int()orz.string()for bothvolumeandissue. The format library atsrc/lib/citations/format.ts:72-73already coerces both via template literals, so no rendering changes are needed.Validation:
npm run validate:citations— 0 errors, 45 unused-reference warnings (non-blocking)npm run build— 913 pages built in 8.71s, no schema errorsUnblocks Phase 3 citation deployment.