fdtd #2
Draft
fdtd #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can we move geometry outside of the fdtd subpackage? I think it would be nice if we have a unified geometry base over all simulators (not only fdtd). |
Add MEEP photonic FDTD simulation with cloud execution: - MeepSim fluent API (set_geometry, set_stack, set_wavelength, etc.) - SimConfig JSON + GDS file + runner script for cloud upload - S-parameter result parsing, port extraction, material resolution - 49 tests Extract shared modules from fdtd into gsim.common: - LayeredComponentBase (ported from gplugins) - GeometryModel + Prism dataclass for solver-agnostic 3D geometry - Visualization backends (PyVista, Open3D, Three.js, Matplotlib) Remove gsim.fdtd (Tidy3D wrapper): - Zero tests, zero usage outside itself - All reusable code already extracted to common
- Add meep-sim-*/ pattern to .gitignore (matches palace-sim-*/ convention) - Update notebook output dir from meep-sim to meep-sim-test - Minor ruff auto-fixes in visualization.py and palace/ports.py
…tests - Add SimOverlay/PortOverlay models for rendering sim cell, PML, ports on 2D slices - Add MarginConfig to meep models (pml_thickness, margin_xy, margin_z) - Expand render2d to draw sim cell boundary, PML regions, source/monitor ports - Add plot_2d() to MeepSim with overlay support - Update run_meep.py template to read margin config instead of hardcoded padding - 62 meep-specific tests passing (was 49), 119 total
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.