Skip to content

meta: document the release process in CONTRIBUTING.md (#93) - #101

Open
avivace wants to merge 2 commits into
masterfrom
contributing-release-process
Open

avivace wants to merge 2 commits into
masterfrom
contributing-release-process

Conversation

@avivace

@avivace avivace commented Oct 15, 2026

Copy link
Copy Markdown
Member

No description provided.

Comment thread README.md
We follow [semantic versioning](https://semver.org).
Breaking changes increase the major version, backwards-compatible changes (typically new additions) only increase the minor version, and bug fixes (including changes to the comments) only increase the patch level.
(An example of a breaking change is when `hardware.inc` 4.0 updated its syntax for compatibility with RGBDS 0.5.0, breaking compatibility with older RGBDS versions.)
See [CONTRIBUTING.md](CONTRIBUTING.md) for how to contribute changes and how releases are made.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's still worth mention in the README that master isn't stable and to use a tagged version

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to mention it in the README, I think it would be more relevant for users than contributors. How about a new sentence at the top: "The latest version of hardware.inc is v6.0.0.", linking to the tagged release. And the CONTRIBUTING.md instructions should say to update this file as well when releasing a new version.

Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
Breaking changes for the new major version are merged into this branch through pull requests targeting it, instead of `master`.
Non-breaking changes keep going to `master` as usual; merge `master` into the version branch periodically to keep it up to date.
2. **Release a candidate.**
When the version branch is ready, update `HARDWARE_INC_VERSION` and `HISTORY.md` on it for the RC version (e.g. `6.0.0-rc1`).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed already for the RCs?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when we published v6.0.0-rc1, it had def HARDWARE_INC_VERSION equs "6.0.0" (ce32c88). That's appropriate so anyone using rev_Check_hardware_inc 5 would not pass it, because the RC already has breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants