Fix pivoting of strategic game tables#860
Conversation
Hi @tturocy here is a screenshot from having built the GUI from this branch and opening a game in strategic form view - does this show the row and column labels looking the way you expect? |
|
@edwardchalstrey1 Try dragging player2 to be on the row labels and see what happens (what you're showing was the case that already worked before) |
|
Yeah, that's not good, does not seem to be sizing correctly. |
|
@tturocy : Does it still make sense for me to test on Linux, given Ed's experience? |
|
@rahulsavani Yes please, it would still be useful information. |
|
@edwardchalstrey1 Which game did you try above? The two (different from your one above) games I tried on Linux both seem to work fine, so ideally I should test your game too... |
|
Ok I just tried rebuilding from this branch again and opening 2smp.efg in strategic form view and dragging player 2 to be on the row labels, and now it looks like this (so I think this is now correctly sizing): 
|
That game works fine for me too on Linux, so I think we are good. |
rahulsavani
left a comment
rahulsavani
left a comment
There was a problem hiding this comment.
Looks good to me on Linux.
At some point, the sizing of row and column labels to accommodate the actual size of labels no longer worked correctly, at least on some platforms. This corrects the sizing logic and ensures that drag-and-drop of players is now working as well. Closes #844.
3 participants
This corrects pivoting of strategic game tables. Specifically, this fixes the resizing of the row and column label panels so they display all of the levels of the index.
Along the way, some internal refactoring is done to separate the local storage of the pivoted view from the user-display wxWidgets level.