Skip to content

fix: reroute file drop to Gutenberg dropzone #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfintal merged 2 commits into from
Jun 8, 2026
Merged

fix: reroute file drop to Gutenberg dropzone #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd5f11d
fix: reroute file drop to Gutenberg dropzone
Arukuen Jun 4, 2026
14871a6
fix: consistent attribute checking
Arukuen Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/admin/js/media-manager/drop-zone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const ALLOWED_LOCATIONS = applyFilters( 'cimo.dropZone.allowedLocations', [
'.editor-styles-wrapper', // Allowed to drop in the block editor when adding new image blocks
'.uploader-window', // Allowed to drop in the admin Media > Library grid view
'.uploader-editor', // Allowed to drop in the WooCommerce description editor
'.block-library-utils__media-control', // Allowed to drop in the block editor image block media control
] )

// Add event listener to the Media Manager's drop zone
Expand Down Expand Up @@ -140,7 +141,7 @@ function addDropZoneListenerToMediaManager( targetDocument ) {
await saveMetadata( conversionMetadata )

// Find the correct target to dispatch the event to
let target = event.target
let target = event.target.closest( '.components-drop-zone, [data-is-drop-zone="true"]' ) || event.target
// This specifically handles the WooCommerce/classic description editor
if ( event.target?.closest( '.uploader-editor-content' ) ) {
target = event.target.closest( '.uploader-editor-content' )
Expand All @@ -154,7 +155,7 @@ function addDropZoneListenerToMediaManager( targetDocument ) {
// inside the DropZoneComponent.
//
// @see https://github.com/WordPress/gutenberg/blob/f8140c4fcc8db2d6078ad76fd433c79df3543860/packages/components/src/drop-zone/index.tsx#L59
if ( target?.classList.contains( 'components-drop-zone' ) || target?.classList.contains( 'uploader-editor-content' ) ) {
if ( target?.classList.contains( 'components-drop-zone' ) || target?.getAttribute( 'data-is-drop-zone' ) === 'true' || target?.classList.contains( 'uploader-editor-content' ) ) {
// Create a drop event with conditional bubbling
// Use bubbles: false when in iframe to prevent doubling, but true for main document
const isInIframe = targetDocument !== document
Expand Down
Loading