Skip to content

harden: variable '(void *) indices' was freed twice in compressMG1.c... #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

harden: variable '(void *) indices' was freed twice in compressMG1.c... #727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions OpenCTM-1.0.3/lib/compressMG1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,15 @@ int _ctmCompressMesh_MG1(_CTMcontext * self)
CTMuint * indices;
_CTMfloatmap * map;
CTMuint i;
size_t indexElemCount;

#ifdef __DEBUG_
printf("COMPRESSION METHOD: MG1\n");
#endif

// Perpare (sort) indices
indices = (CTMuint *) malloc(sizeof(CTMuint) * self->mTriangleCount * 3);
indexElemCount = (size_t) self->mTriangleCount * 3;
indices = (CTMuint *) calloc(indexElemCount, sizeof(CTMuint));
if(!indices)
{
self->mError = CTM_OUT_OF_MEMORY;
Expand Down Expand Up @@ -185,7 +187,6 @@ int _ctmCompressMesh_MG1(_CTMcontext * self)
_ctmStreamWrite(self, (void *) "VERT", 4);
if(!_ctmStreamWritePackedFloats(self, self->mVertices, self->mVertexCount * 3, 1))
{
free((void *) indices);
return CTM_FALSE;
}

Expand Down Expand Up @@ -241,9 +242,11 @@ int _ctmUncompressMesh_MG1(_CTMcontext * self)
CTMuint * indices;
_CTMfloatmap * map;
CTMuint i;
size_t indexElemCount;

// Allocate memory for the indices
indices = (CTMuint *) malloc(sizeof(CTMuint) * self->mTriangleCount * 3);
indexElemCount = (size_t) self->mTriangleCount * 3;
indices = (CTMuint *) calloc(indexElemCount, sizeof(CTMuint));
if(!indices)
{
self->mError = CTM_OUT_OF_MEMORY;
Expand Down