Fix check_test_class_names test - #23085
Merged
Merged
Conversation
I broke the CI workflow by mistake in commit 3788424 . While fixing that, I noticed that the `.ci/check_test_class_names.sh` script wasn't properly collecting integration and integration Selenium tests because of these errors: ``` ERROR test/integration - Failed: Defining 'pytest_plugins' in a non-top-level conftest is no longer supported: ERROR test/integration_selenium - Failed: Defining 'pytest_plugins' in a non-top-level conftest is no longer supported: ``` Fixed them by passing to `pytest` all the direct subdirectories instead of `test/`.
nsoranzo
force-pushed
the
fix_check_test_class_names
branch
from
July 8, 2026 10:46
0b0a612 to
837d311
Compare
mvdbeek
approved these changes
Jul 8, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I broke the CI workflow by mistake in #23028 .
While fixing that, I noticed that the
.ci/check_test_class_names.shscript wasn't properly collecting integration and integration Selenium tests because of these errors:Fixed them by passing to
pytestall the direct subdirectories instead oftest/.How to test the changes?
(Select all options that apply)
License