Skip to content

Show newer available tool version badge in tool form and empty-parameter state more clearly - #23046

Merged
mvdbeek merged 12 commits into
galaxyproject:devfrom
itisAliRH:feat/tool-form-latest-version-badge-empty-params
Jul 15, 2026
Merged

mvdbeek merged 12 commits into
galaxyproject:devfrom
itisAliRH:feat/tool-form-latest-version-badge-empty-params

Conversation

@itisAliRH

@itisAliRH itisAliRH commented Jul 1, 2026

Copy link
Copy Markdown
Member

This PR makes two potentially ambiguous tool-form states explicit:

  • When an older tool version is active, shows a Newer version available warning badge beside the version. The badge includes a tooltip and navigates to the same tool with version=latest when clicked.
  • When a tool has no input parameters, shows an informational alert so the empty Tool Parameters section is not mistaken for a loading or rendering failure.

The version badge remains hidden when the latest version is active or when the tool has only one version.

Newer version available

image

No input parameters

image

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Open a tool with multiple versions and select an older version.
    2. Confirm the header shows the Newer version available badge.
    3. Hover over or focus the badge and confirm the tooltip explains that it switches to the latest version.
    4. Click the badge and confirm navigation keeps the same tool_id and uses version=latest.
    5. Confirm the badge is absent when the latest version is active.
    6. Open a tool without input parameters, such as /?tool_id=interactive_tool_loom&version=latest.
    7. Confirm the Tool Parameters section shows: This tool requires no input parameters and can be run as is.

License

  • I agree to license these and all my past contributions to the core Galaxy codebase under the MIT license.

@mvdbeek

mvdbeek commented Jul 7, 2026

Copy link
Copy Markdown
Member

Don't we want a badge that says that we do have a newer version when opening an older tool ?
If you're already using the latest version it seems like a distraction ?

Add the inverse presentation state without changing existing ToolCard behavior, allowing caller migration separately.
Compare the active tool version with the final lineage entry so latest and single-version tools remain unflagged.
Use the version=latest alias instead of resolving and passing a concrete tool revision through the component tree.
@itisAliRH itisAliRH changed the title Show latest version badge in tool form and empty-parameter state more clearly Show newer available tool version badge in tool form and empty-parameter state more clearly Jul 14, 2026
@itisAliRH

Copy link
Copy Markdown
Member Author

Don't we want a badge that says that we do have a newer version when opening an older tool ? If you're already using the latest version it seems like a distraction ?

@mvdbeek Good point. I agree that the actionable state is when an older version is selected. I inverted the behavior so that a "Newer version available" badge is shown only when a newer selectable version exists, while the latest and single-version tools remain quiet.

@mvdbeek mvdbeek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach looks good, happy to merge when it's green.

@mvdbeek
mvdbeek merged commit e83fb88 into galaxyproject:dev Jul 15, 2026
26 of 28 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in Galaxy Dev - weeklies Jul 15, 2026
@itisAliRH
itisAliRH deleted the feat/tool-form-latest-version-badge-empty-params branch July 15, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

2 participants