Conversation
Contributor
Author
|
Ping @hechth |
24 tasks
Member
|
Looks good to me, can you update the PR @PlushZ ? |
PlushZ
force-pushed
the
migrate-irods-fs-to-fsspec
branch
from
July 9, 2026 16:36
4850481 to
422b402
Compare
Member
|
can you run |
|
for the time being, we're still testing our implementation of the fsspec here: https://github.com/RECETOX/fs-irods/tree/fsspec |
mvdbeek
reviewed
Jul 21, 2026
| omero-py #type: omero | ||
| iiif-fsspec # type: iiif | ||
| fs-irods # type: irods, depends on python-irodsclient | ||
| mangofs @ git+https://gitlab.kuleuven.be/setit/rdm/mango-fsspec.git@1.1.0 # type: irods, depends on python-irodsclient |
Member
There was a problem hiding this comment.
Probably want this resolved before merging.
Contributor
Author
There was a problem hiding this comment.
yeah, waiting for the package being tested and published.
11 tasks
Member
|
I'm moving this Draft - can you take it back out of draft once that package has been published and this has been rebased. Also feel free to ping me for a review at that time. Thanks for all the work on these file sources - very exciting! |
jmchilton
marked this pull request as draft
September 16, 2026 16:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates iRODs pyFileSystem2 outdated filesource to fsspec backed with https://gitlab.kuleuven.be/setit/rdm/mango-fsspec
Configuration of file source is not changed.
https://gitlab.kuleuven.be/setit/rdm/mango-fsspec library should be published before merging and changed in conditional requirements.txt
How to test the changes?
(Select all options that apply)
irods-catalog-providerandirods-client-icommandsservices. Expose the iRODS provider port to the host with adocker-compose.override.yml:License