Migrate BModal components to GModal - final batch - #23023
Merged
itisAliRH merged 30 commits intoAug 13, 2026
Merged
Conversation
ahmedhamidawan
added
kind/enhancement
area/UI-UX
kind/refactoring
ahmedhamidawan
force-pushed
the
b-modal-to-g-modal-batch-2
branch
2 times, most recently
from
August 4, 2026 16:21
dadf86b to
8411d96
Compare
ahmedhamidawan
changed the title
ahmedhamidawan
marked this pull request as ready for review
August 5, 2026 18:44
itisAliRH
self-requested a review
August 11, 2026 10:37
itisAliRH
requested changes
Aug 11, 2026
itisAliRH
left a comment
itisAliRH
left a comment
Member
There was a problem hiding this comment.
Thank you @ahmedhamidawan!
I tested the changes and found a few issues.
ahmedhamidawan
added a commit
to ahmedhamidawan/galaxy
that referenced
this pull request
Aug 11, 2026
As reported in galaxyproject#23023 (comment), we were checking a nonexistent modal class (g-modal wheras we needed to check g-dialog).
ahmedhamidawan
added a commit
to ahmedhamidawan/galaxy
that referenced
this pull request
Aug 11, 2026
Reported in galaxyproject#23023 (comment) that the modal calls the `onCancel` method before actually saving sharing preferences. A local ref now handles the cancel and ok events separately.
ahmedhamidawan
added a commit
to ahmedhamidawan/galaxy
that referenced
this pull request
Aug 11, 2026
Member
Author
|
@itisAliRH Pushed several commits that fix your findings. Could you please try this out now to see if the same errors show up? Thank you!! |
Member
|
Thanks for the update @ahmedhamidawan! Four of the five issues are fixed👍🏻 |
Co-Authored-By: Claude <noreply@anthropic.com>
There is no built-in `open` event for `dialog`s that we can listen to.
…y UIs We were using popovers which weren't quite needed to describe the object stores since we can simply use cards which describe AND allow the user to select/filter by the object store.
We need to keep it open if the import errors out. Co-authored-by: Alireza Heidari <itisalirh@gmail.com>
As reported in galaxyproject#23023 (comment), we were checking a nonexistent modal class (g-modal wheras we needed to check g-dialog).
Reported in galaxyproject#23023 (comment) that the modal calls the `onCancel` method before actually saving sharing preferences. A local ref now handles the cancel and ok events separately.
…el flow Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Alireza Heidari <itisalirh@gmail.com>
ahmedhamidawan
force-pushed
the
b-modal-to-g-modal-batch-2
branch
from
August 13, 2026 16:34
ad7de4f to
f5fd3eb
Compare
itisAliRH
approved these changes
Aug 13, 2026
itisAliRH
left a comment
itisAliRH
left a comment
Member
There was a problem hiding this comment.
LGTM! Thank you @ahmedhamidawan!
github-project-automation
Bot
moved this from Needs Review
to Done
in Galaxy Dev - weeklies
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tackles several more components from #21976
Fixes #21976
How to test the changes?
(Select all options that apply)
License