Add jobs panel to activity bar#23005
Conversation
ahmedhamidawan
added
kind/feature
highlight
davelopez
left a comment
davelopez
left a comment
There was a problem hiding this comment.
Hi @agnesbrnb!
This is great! and it would be amazing to have this pushed to the finishing line, do you need any help with that?
Here are some comments for making it ready 👍
| export async function fetchJobs(){ | ||
| const { data, error } = await GalaxyApi().GET("/api/jobs"); |
There was a problem hiding this comment.
This will list every job independent of the state, so it is better to use pagination here; for that, you can use the limit and offset parameters. You can get inspiration, for example, from the InvocationsScrollList component.
Another important issue here is that, in the case of an admin user, this will list all users' jobs by default, which is definitely not something you want 😅, so even if it is not necessary for regular users, we should pass the current user_id to the endpoint to ensure admins only see their own jobs here.
|
|
||
| <template> | ||
| <ActivityPanel | ||
| title="Running jobs" |
There was a problem hiding this comment.
The title "Running Jobs" is a bit misleading, since this is showing all jobs regardless of their status.
| <ActivityPanel | ||
| title="Running jobs" | ||
| go-to-all-title="Open Jobs List" | ||
| href="/workflows/jobs"> |
There was a problem hiding this comment.
I think this /workflows/jobs is a hallucination 😅 and will display a blank page since it is not implemented. Also, it should probably be just jobs/; the word workflows here could be misleading.
3 participants
Related to issue: #20619
How to test the changes?
(Select all options that apply)
License