feat(sdk-next): add uniswap v3 pool venue#333
Open
iamyxsh wants to merge 3 commits into
Open
Conversation
Adds the pool/uniswapv3 venue (Pool, PoolClient, sync quote math + specs) omitted from 76edfb1; bumps sdk-next to 1.4.0.
🦋 Changeset detectedLatest commit: 2f0929e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for galactic-apps ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
iamyxsh
requested a deployment
to
upgrade-ui-master
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Uniswap v3 venue to the sdk-next router:
UniswapV3Pool/PoolClient(EVM factory pool discovery, slot0/liquidity reads) and a sync tick-walk quote (UniswapV3Math) proven wei-exact vs@uniswap/v3-sdk. Wired through PoolFactory / PoolContextProvider / SOR / TradeRouteBuilder via.withV3().Tests:
UniswapV3Math28/28,tsc --noEmitclean. ThePool/PoolClientspecs are blocked by the pre-existing repo-wide jest ESM/commontransform issue (unrelated to this venue).