Add Mark as watched to video menus - #990
Open
jerichokeyne wants to merge 1 commit into
Open
Conversation
Port the Android action so videos can be added to history without playing them, which also feeds the subscriptions watched filter. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Please sign our contributor license agreement at https://cla.futo.tech |
|
Please sign our contributor license agreement at https://cla.futo.tech |
Author
|
I've signed the CLA now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to port the Android "Add to History" action so videos can be added to history without playing them, which also feeds the subscriptions watched filter.
I tested this locally on my Fedora 44 machine, and it appears to work well. I was able to mark items as watched, see them in the history tab, see that the "Watched" filter in the subscription tab filters them out, and check that videos played normally are still added to the history tab too.
This was developed using Cursor. I'm not too sure what your AI usage policy is though, so I figured I'd make it clear that this was AI generated
Fixes #81
I'm also happy to update this to rename the button to "Add to History" if desired, but I personally feel like "Mark as watched" is a little easier to parse