Conversation
shimwell
commented
Jan 26, 2022
| return fig | ||
|
|
||
|
|
||
| def plot_projected_position_from_initial_source( |
Member
Author
There was a problem hiding this comment.
Suggested change
| def plot_projected_position_from_initial_source( | |
| def plot_position_with_geometry_from_initial_source( |
shimwell
commented
Jan 26, 2022
Comment on lines
+132
to
+133
| input_filename="initial_source.h5", axis="XY" | ||
| ): |
Member
Author
There was a problem hiding this comment.
Suggested change
| input_filename="initial_source.h5", axis="XY" | |
| ): | |
| input_filename="initial_source.h5", | |
| h5m_filename="dagmc.h5m", | |
| axis="XY" | |
| ): |
Member
Author
|
This probably needs plotly support to be added to the dagmc_geometry_slice_plotter or alternatively matplotlib support to be added to this package |
Member
Author
|
putting this on hold because the downstream deps are being updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress
This PR will allow projections of the source to be plotted, ideal for producing source plots on dagmc geometry with the dagmc_geometry_slice_plotter.
TODO