Repository navigation
move settings into a tab on the bugsack popup and avoid taint - #213
Merged
Merged
Conversation
Owner
|
Nice work! I'll play around with it a bit and see how things go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heres the PR with changes we discussed in #210. I like and prefer this approach a lot, neat to have it all in one window. Added benefit is the avoided taint issue, none that I can replicate now anyway. Would love to see it upstream either by this PR or you picking whatever you want from it 👍
Forever (and Retail but less bronze)



Classic
SettingsPanel window