Repository navigation
test: keep the manifest and shell theme colors on the brand token - #142
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 778 778
Branches 155 155
=========================================
Hits 778 778 ☔ View full report in Codecov by Harness. |
Contributor
funkadelic
marked this pull request as ready for review
October 7, 2026 21:08
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…steps for what they do
Bundle ReportBundle size has no change ✅ |
Lighthouse, median of 3 mobile runs
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fails CI when the app's theme color drifts from the brand color token, and renames three CI checks to say what they run
Summary by cubic
Adds a test that fails CI when the app's theme color drifts from the brand color token, and renames CI jobs and steps to match what they do.
The web manifest and
<meta name="theme-color">can't read a CSS custom property, so the brand hex is copied into each; the test holds every copy to the token and reads the theme-color meta regardless of attribute order. The CI changes rename the end-to-end sweep to "End-to-end tests", the Lighthouse step to "Lighthouse (advisory)", and the report job to "Lighthouse report".Written for commit 5fb7910. Summary will update on new commits.