Skip to content

docs: keep the search debounce - #141

Merged
funkadelic merged 4 commits into
mainfrom
docs/keep-search-debounce
Oct 8, 2026
Merged

funkadelic merged 4 commits into
mainfrom
docs/keep-search-debounce

Conversation

@funkadelic

@funkadelic funkadelic commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

records keeping the search debounce, with typing-latency checks at two typing speeds


Summary by cubic

Records the decision to keep the 150 ms search debounce, backed by typing-latency measurements that show a React-transitions alternative was no faster.

  • Adds ADR 0017 documenting the comparison and the decision; no search code changes.
  • Adds latency specs typing a search term at 50 and 200 ms per key, with budgets for slowest key, blocking time, and time to settled results.
  • Replaces the debounce-magnitude assertion on the existing search spec with a dead-probe check, so the test no longer pins the delay duration.

Written for commit 2be0a77. Summary will update on new commits.

View guided diff Turn on auto-fix

@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (db5396b) to head (2be0a77).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           51        51           
  Lines          778       778           
  Branches       155       155           
=========================================
  Hits           778       778           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Lighthouse, median of 3 mobile runs

Page Score FCP LCP TBT CLS Speed Index
Cities 100 1.1s 1.4s 17ms 0.000 1.1s
Films 94 1.1s 3.0s 0ms 0.000 1.1s

Full reports

@codspeed

codspeed Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 26 untouched benchmarks


Comparing docs/keep-search-debounce (2be0a77) with main (b1ed641)

Open in CodSpeed

@funkadelic
funkadelic marked this pull request as ready for review October 8, 2026 18:13

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread e2e/latency.spec.ts Outdated
Comment thread e2e/latency.spec.ts Outdated
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@funkadelic
funkadelic merged commit bd26f7e into main Oct 8, 2026
16 checks passed
@funkadelic
funkadelic deleted the docs/keep-search-debounce branch October 8, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant