Skip to content

Conversation

@gusty
Copy link
Member

@gusty gusty commented Dec 26, 2025

TaskBuilder tests were failing since long, randomly.

Recent history shows:

Bump to Fable 4.27 and adjust ifdef for Fable4 (#649) #2498
-> Exception:  System.Exception: ran next too early at FSharpPlus.Tests.Task.TaskBuilderTests.test2ndExceptionThrownInFinally() in D:\a\FSharpPlus\FSharpPlus\tests\FSharpPlus.Tests\Task.fs:line 718

Rename non-sequential applicative CEs to zapp (#650) #2511
-> Exception: FSharpPlus.Tests.Task+TaskBuilderTests+TestException: TestException "finally exn!"
            at [email protected](Unit unitVar) in D:\a\FSharpPlus\FSharpPlus\tests\FSharpPlus.Tests\Task.fs:line 689

Add InlineIfLambda to Free (#628) #2512
-> Exception: 
         FSharpPlus.Tests.Task+TaskBuilderTests+TestException: TestException "finally exn!"

Add missing type param to Task.raise #2513
-> Exception:
         FSharpPlus.Tests.Task+TaskBuilderTests+TestException: TestException "finally exn!"
            at [email protected](Unit unitVar) in D:\a\FSharpPlus\FSharpPlus\tests\FSharpPlus.Tests\Task.fs:line 689

Run dotnet workflows on Ubuntu (#651) #2518
-> Exception: 
         System.Exception: sleep blocked caller
            at FSharpPlus.Tests.Task.TaskBuilderTests.testNonBlocking() in /home/runner/work/FSharpPlus/FSharpPlus/tests/FSharpPlus.Tests/Task.fs:line 316
            at FSharpPlus.Tests.Task.TaskBuilderTests.taskbuilderTests() in /home/runner/work/FSharpPlus/FSharpPlus/tests/FSharpPlus.Tests/Task.fs:line 945
         Running taskbuilder tests...

Add note about style #2532
-> FSharpPlus.Tests.Task+TaskBuilderTests+TestException: TestException "finally exn!"

Fix several functions in ResizeArray #2545
-> Exception: 
         FSharpPlus.Tests.Task+TaskBuilderTests+TestException: TestException "finally exn!"

Use nullArgCheck and pin signatures (#653)
-> Exception: 
         System.Exception: sleep blocked caller
            at FSharpPlus.Tests.Task.TaskBuilderTests.testNonBlocking() in /home/runner/work/FSharpPlus/FSharpPlus/tests/FSharpPlus.Tests/Task.fs:line 316

Add missing type param to ValueTask.raise #2580
-> Passed all tests!

Fix ValueTask.ignore #2581
-> Exception: 
         System.Exception: sleep blocked caller
            at FSharpPlus.Tests.Task.TaskBuilderTests.testNonBlocking() in /home/runner/work/FSharpPlus/FSharpPlus/tests/FSharpPlus.Tests/Task.fs:line 316

+ orElse(With) for (Value)Task #2605
-> Exception: 
         System.Exception: sleep blocked caller
            at FSharpPlus.Tests.ValueTask.ValueTaskBuilderTests.testNonBlocking() in /home/runner/work/FSharpPlus/FSharpPlus/tests/FSharpPlus.Tests/ValueTask.fs:line 266

Fix parameters order in tryWith/Finally for Task #2608
-> Exception: 
         System.Exception: sleep blocked caller
            at FSharpPlus.Tests.ValueTask.ValueTaskBuilderTests.testNonBlocking() in /home/runner/work/FSharpPlus/FSharpPlus/tests/FSharpPlus.Tests/ValueTask.fs:line 266

Apart from that #653 gave

-> Exception: 
         System.AggregateException: One or more errors occurred. (Stack depth increased!)
          ---> System.Exception: Stack depth increased!
            at [email protected](Unit _arg1) in /home/runner/work/FSharpPlus/FSharpPlus/tests/FSharpPlus.Tests/Task.fs:line 739
            at FSharpPlus.Task.map[T,U](FSharpFunc`2 f, Task`1 source) in /home/runner/work/FSharpPlus/FSharpPlus/src/FSharpPlus/Extensions/Task.fs:line 24

@gusty gusty force-pushed the gus/task-fixes branch 4 times, most recently from 74d5a2c to e8d19f9 Compare December 26, 2025 20:21
@gusty gusty force-pushed the gus/task-fixes branch 2 times, most recently from 68e10ea to b108c62 Compare December 27, 2025 06:55
@gusty gusty force-pushed the gus/task-fixes branch 2 times, most recently from 52ee269 to 6a985da Compare December 27, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants