Skip to content

enclose.moose localization and improvements - #352

Open
MikaeldeVerdier wants to merge 9 commits into
masterfrom
enclose_moose_localization
Open

enclose.moose localization and improvements#352
MikaeldeVerdier wants to merge 9 commits into
masterfrom
enclose_moose_localization

Conversation

@MikaeldeVerdier

@MikaeldeVerdier MikaeldeVerdier commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

marksam32
marksam32 previously approved these changes Sep 2, 2026
View reviewed changes

@marksam32 marksam32 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marksam32

marksam32 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

However I do wonder, have you ever received this error from running the game on iOS?
SWIFT TASK CONTINUATION MISUSE: setUpPlayerItemStatusObservation(_:) leaked its continuation without resuming it. This may cause tasks waiting on it to remain suspended forever.

Some quick googling led me to believe that it has something to do with line 729-730 in enclode_moose_level_page.dart where the audio player get's released and then played. But if you spam click the moose before the original audio player is "ready" it gives this error. Didn't cause any issues in the simulator but maybe something to look out for? Also was not able to reproduce it after the first time it threw that error for some reason.

@MikaeldeVerdier

MikaeldeVerdier commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

I wasn't able to recreate either but made some changes that should be safer (avoids using player.release at all).

@MikaeldeVerdier
added fittedBoxes (scale down) in some places to avoid overflow on sm…
5e272de 
…all screens (mostly enclose.moose but also the navigation bottom bar buttons)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgelgeback georgelgeback Awaiting requested review from georgelgeback
@marksam32 marksam32 Awaiting requested review from marksam32

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MikaeldeVerdier @marksam32